Conversation
- Remove parser repoRoot global, thread root parameter (CRITICAL) - Fix FetchAll data races with teamPartials struct - Add GetProfiles pagination loop - Validate Fleet server URL with url.Parse - Warn on insecure HTTP and world-readable config files - Reject .. in branch names, enforce HTTPS in doRequest - Add -- separator to git fetch/diff commands - Add .. path traversal check in scope.go - Escape resource names in markdown table cells - Sanitize HTTPError body (strip newlines) - Remove repoRoot global, accept .yaml team files - Error on non-map YAML overlay in merge - Report query logging changes to empty string - Deduplicate matchesAnyTeam, normalizeSoftwarePath - Remove bare block scope in diffSoftware - Fix stale docs: API endpoints, config paths, merge description Ref #20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
repoRootglobal state (threadrootparameter)FetchAllgoroutines (teamPartialsstruct)GetProfilespagination,url.Parsevalidation, insecure HTTP warning..branch rejection, HTTPS enforcement,--git arg separator, path traversal check, markdown escaping, HTTPError sanitizationmatchesAnyTeam/normalizeSoftwarePath, remove bare block scopeTest plan
go build ./...passesgo test ./...passes (all 9 packages)Ref #20