Skip to content

Conversation

@paulhovey
Copy link
Contributor

When using force_zone_number or force_zone_letter in from_latlon(), there is no check to make sure the inputs are valid. I broke that into a separate function and added unit tests for that function individually, and in failing cases to from_latlon(). No other tests broke, so it should be working as expected.

@codecov
Copy link

codecov bot commented Jul 11, 2018

Codecov Report

Merging #32 into master will increase coverage by 1.49%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #32      +/-   ##
=======================================
+ Coverage    93.5%   95%   +1.49%     
=======================================
  Files           3     3              
  Lines         154   160       +6     
=======================================
+ Hits          144   152       +8     
+ Misses         10     8       -2
Impacted Files Coverage Δ
utm/__init__.py 100% <100%> (ø) ⬆️
utm/conversion.py 94.87% <100%> (+1.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81883cc...3ae04b2. Read the comment docs.

@Turbo87
Copy link
Owner

Turbo87 commented Jul 16, 2018

Nice work, thanks @paulhovey!

@Turbo87 Turbo87 merged commit efdd46a into Turbo87:master Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants