Skip to content

Conversation

@Thebloxers998
Copy link

Just a OAuth Extension that you probably won't use anyways or it'll probably get closed or whatever

@github-actions github-actions bot added the pr: new extension Pull requests that add a new extension label Feb 4, 2025
@Thebloxers998
Copy link
Author

!format

@Thebloxers998
Copy link
Author

!format

@Thebloxers998
Copy link
Author

!format

@Thebloxers998
Copy link
Author

I need help on the lint

Copy link

@hammouda101010 hammouda101010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

obviously, there are alot of problems that are easy to fix.

@Thebloxers998
Copy link
Author

!format

@ghost
Copy link

ghost commented Mar 7, 2025

how to make it work?

@Thebloxers998
Copy link
Author

how to make it work?

You need to set everything up

@Thebloxers998
Copy link
Author

Thebloxers998 commented Mar 29, 2025

how to make it work?

For the redirect url, you could package your project and deploy it to something like Netlify

Or use https://share.turbowarp.org

@lselden
Copy link

lselden commented Mar 30, 2025

Encouraging anyone to expose their OAuth client secret isn't good practice. Consider changing this to use a PKCE flow instead - it only requires a client ID and the redirect URL to be defined.

@Thebloxers998
Copy link
Author

Encouraging anyone to expose their OAuth client secret isn't good practice. Consider changing this to use a PKCE flow instead - it only requires a client ID and the redirect URL to be defined.

Ok

@Brackets-Coder
Copy link
Contributor

I'm closing this -- it relies on wayyy to many external features that does not follow best practices for TW

The concept is a good idea, but what exactly is it for, other than checking if you're online at a particular platform

the domains could go down, be blocked/whitelisted, and I think External APIs (especially those that require a key) are generally forbidden in the contributing guidelines because of security concerns anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: new extension Pull requests that add a new extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants