-
Notifications
You must be signed in to change notification settings - Fork 316
OAuth #1906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OAuth #1906
Conversation
|
!format |
|
!format |
|
!format |
|
I need help on the lint |
hammouda101010
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
obviously, there are alot of problems that are easy to fix.
|
!format |
|
how to make it work? |
You need to set everything up |
For the redirect url, you could package your project and deploy it to something like Netlify Or use https://share.turbowarp.org |
|
Encouraging anyone to expose their OAuth client secret isn't good practice. Consider changing this to use a PKCE flow instead - it only requires a client ID and the redirect URL to be defined. |
Ok |
|
I'm closing this -- it relies on wayyy to many external features that does not follow best practices for TW The concept is a good idea, but what exactly is it for, other than checking if you're online at a particular platform the domains could go down, be blocked/whitelisted, and I think External APIs (especially those that require a key) are generally forbidden in the contributing guidelines because of security concerns anyway. |
Just a OAuth Extension that you probably won't use anyways or it'll probably get closed or whatever