Skip to content

Conversation

@penelopeysm
Copy link
Member

@penelopeysm penelopeysm commented Oct 7, 2025

cf. TuringLang/Turing.jl#2678

Sometimes, step_warmup() needs to know how many warmup steps it's doing. This is the case for adaptive Hamiltonians, which call AdvancedHMC.adapt!, which has different behaviour depending on whether it's the first warmup step, last warmup step, or something in between (see here).

This PR therefore exposes this information to step_warmup (previously, the num_warmup kwarg would have been 'swallowed' by mcmcsample).

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2025

AbstractMCMC.jl documentation for PR #178 is available at:
https://TuringLang.github.io/AbstractMCMC.jl/previews/PR178/

@penelopeysm penelopeysm merged commit e15d26c into main Oct 7, 2025
27 of 28 checks passed
@penelopeysm penelopeysm deleted the py/pass-num-warmup branch October 7, 2025 12:32
@codecov
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (ae9760d) to head (fdab17c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #178   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants