-
Notifications
You must be signed in to change notification settings - Fork 37
Rename keyword argument only_ddpl to only_dppl and bump patch version
#1106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
is there any mistake? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1106 +/- ##
=======================================
Coverage 81.23% 81.23%
=======================================
Files 40 40
Lines 3805 3805
=======================================
Hits 3091 3091
Misses 714 714 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
is everything okay or should i change something? |
|
Hi @elsakarvouni, thanks for the PR! Could you please remove the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a small edit and am happy to approve. Will merge once tests pass.
Thanks @elsakarvouni, always a great pleasure to receive a contribution from someone new to the project.
This PR renames the keyword argument
only_ddpltoonly_dpplas requested in issue #1104.Since the relevant functions are not exported, this change is fully backward-compatible.
The patch version has been bumped in Project.toml accordingly.