Skip to content

Conversation

@elsakarvouni
Copy link
Contributor

This PR renames the keyword argument only_ddpl to only_dppl as requested in issue #1104.
Since the relevant functions are not exported, this change is fully backward-compatible.
The patch version has been bumped in Project.toml accordingly.

@elsakarvouni
Copy link
Contributor Author

is there any mistake?

@codecov
Copy link

codecov bot commented Nov 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.23%. Comparing base (13b79a8) to head (72cc657).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1106   +/-   ##
=======================================
  Coverage   81.23%   81.23%           
=======================================
  Files          40       40           
  Lines        3805     3805           
=======================================
  Hits         3091     3091           
  Misses        714      714           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@elsakarvouni
Copy link
Contributor Author

is everything okay or should i change something?

@mhauru
Copy link
Member

mhauru commented Nov 3, 2025

Hi @elsakarvouni, thanks for the PR! Could you please remove the .idea files from the pull request, since that folder is specific the IDE you're using? Also, if you could add a couple of new lines in HISTORY.md that just say, under the heading of this new version number, what the change is that you've made. Otherwise this looks good and tests pass too.

Copy link
Member

@mhauru mhauru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a small edit and am happy to approve. Will merge once tests pass.

Thanks @elsakarvouni, always a great pleasure to receive a contribution from someone new to the project.

@mhauru mhauru enabled auto-merge November 5, 2025 08:10
@mhauru mhauru added this pull request to the merge queue Nov 5, 2025
Merged via the queue into TuringLang:main with commit d9af270 Nov 5, 2025
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants