-
Notifications
You must be signed in to change notification settings - Fork 37
disable fallback for returned and pointwise_logdensities #1159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Benchmark Report
Computer InformationBenchmark Results |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1159 +/- ##
=======================================
Coverage 81.58% 81.58%
=======================================
Files 40 40
Lines 3845 3845
=======================================
Hits 3137 3137
Misses 708 708 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This needs tests, but I won't do it today. |
|
DynamicPPL.jl documentation for PR #1159 is available at: |
sunxd3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make tons of sense
It turns out I actually also fixed this in #1130, so this is really just a backport to 0.38.
For an example of the problematic behaviour, run this with current Turing release + DPPL 0.38.9:
This PR changes it such that the call to
returnederrors instead of silently giving wrong results.Note that FlexiChains works correctly (both before and after this PR):