Add tests for threaded assume statements#1340
Merged
penelopeysm merged 2 commits intomainfrom Mar 30, 2026
Merged
Conversation
Contributor
Benchmark Report
Computer InformationBenchmark Results |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1340 +/- ##
==========================================
+ Coverage 78.13% 78.41% +0.27%
==========================================
Files 50 50
Lines 3590 3590
==========================================
+ Hits 2805 2815 +10
+ Misses 785 775 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since accumulators are threadsafe (or to be precise, DynamicPPL can make them threadsafe when the user calls
setthreadsafe), any functionality in DynamicPPL that only uses accumulators is automatically threadsafe. This means that, for example, you can sample random variables in parallel:This functionality has always existed (since #1284). I didn't realise at the time that that meant that even LogDensityFunction is now fully threadsafe. This PR just adds tests to verify that.