detect duplicates in threads

[hardik-xi11]

final changes to close #1157

[codecov]

Codecov Report

❌ Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 78.49%. Comparing base (2748445) to head (8ad8c92).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/accumulators/raw_values.jl	93.33%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1342      +/-   ##
==========================================
+ Coverage   78.43%   78.49%   +0.06%     
==========================================
  Files          50       50              
  Lines        3593     3608      +15     
==========================================
+ Hits         2818     2832      +14     
- Misses        775      776       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[penelopeysm]

Thanks for taking this on @hardik-xi11! I like it, just one minor comment. As usual, can you bump the patch and add a changelog too please.

[penelopeysm]

I don't think you need to make the skeleton here; you can just write template_from_acc2_vales = get(acc2.values.data, top_sym, NoTemplate()) since the actual value in the VNT doesn't matter, only the structure.

[penelopeysm]

There's an interesting edge case here which is what should the template be if acc2 and acc1 have different templates, in other words, what happens if acc1 and acc2 both already contain x[1]. I think currently DynamicPPL will ignore the template and it will just use the structure inside acc1. That's not a problem in and of itself, but it might be worth a comment somewhere.

[hardik-xi11]

everything should be good now

[penelopeysm]

Wonderful, thanks!