Skip to content

Update Julia version compatibility in Project.toml #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update Julia version compatibility in Project.toml #201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Aqua = "0.8.11"
JuliaFormatter = "1.0.62"
MistyClosures = "2.0.0"
Test = "1"
julia = "~1.10.8, 1.11.6"
julia = "~1.10.8, 1.11.6, 1.12.1"
Copy link
Member

@mhauru mhauru Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
julia = "~1.10.8, 1.11.6, 1.12.1"
julia = "~1.10.8, ~1.11.6, ~1.12.1"

If the intent is to rule out 1.12.0, I think you need the extra tilde. I would also add a tilde in front of 1.12.1 to not claim that this means compatibility with 1.13.

Note though that this means that if you install Libtask on Julia 1.12.0 you'll get an old version, because the previous release that has julia = "~1.10.8, 1.11.6" as its compat is considered compatible with 1.12.0.

We were discussing this with Will last week. In a philosophical sense Libtask and Mooncake should both have an upper bound on their Julia version compatibility, because they rely on non-public compiler internals. But we can't really introduce one any more, because Pkg will just default to installing an old version that claims to be compatible with anything up to Julia v2.0.

Given that we can't actually stop a broken version of Libtask from being installed on 1.12.0, I think it's less confusing if at least it would install the latest version of Libtask. It would also cause less trouble by holding back other packages. Hence I'm inclined to not do this change.

Copy link
Member Author

@yebai yebai Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we instead print a warning message if Libtask is used on Julia 1.12.0?

Copy link
Member

@mhauru mhauru Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's a good idea.

Copy link
Member

@mhauru mhauru Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a warning in 6c336b0


[extras]
Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
Expand Down
Loading