Skip to content

Conversation

@mhauru
Copy link
Member

@mhauru mhauru commented Nov 7, 2025

Attempting to fix #207. The current version fixes the MWE, but I've failed to make it into a test (the MWE stops crashing once you wrap it in a testset). Hoping to run the Turing tests against this though.

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Libtask.jl documentation for PR #209 is available at:
https://TuringLang.github.io/Libtask.jl/previews/PR209/

@mhauru
Copy link
Member Author

mhauru commented Nov 7, 2025

Local testing indicates that the particle MCMC tests in Turing should pass with this (at least most do), and the performance gains are kept. Still need to figure out how to do the test case for this in Libtask's suite.

@Technici4n
Copy link
Contributor

the MWE stops crashing once you wrap it in a testset

You could maybe try to look at the IR you get for the function and see what the type of the phi node is? Testsets are supposed to behave like global statements so I'm a little surprised.

@mhauru
Copy link
Member Author

mhauru commented Nov 7, 2025

I found a variant of the MWE that fails in a testset too. @Technici4n, would you be happy to review? If this makes sense to you we could release straight-away, assuming CI comes out fine.

@mhauru mhauru marked this pull request as ready for review November 7, 2025 11:34
Copy link
Contributor

@Technici4n Technici4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mhauru
Copy link
Member Author

mhauru commented Nov 7, 2025

The integration tests are still running, but I did the crucial parts locally and so far they seem fine on CI too, and I need to run off now until Monday, so I'm just gonna risk it. It went so well with #205.

@mhauru mhauru merged commit fa576f8 into main Nov 7, 2025
13 of 14 checks passed
@mhauru mhauru deleted the mhauru/207 branch November 7, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Libtask v0.9.9 breaks Union types

3 participants