Skip to content

Add arg: cutoff into fock_combinations for better performance#46

Merged
sansiro77 merged 4 commits intoTuringQ:mainfrom
Jooyuza:feature_combinations
Oct 9, 2024
Merged

Add arg: cutoff into fock_combinations for better performance#46
sansiro77 merged 4 commits intoTuringQ:mainfrom
Jooyuza:feature_combinations

Conversation

@Jooyuza
Copy link
Collaborator

@Jooyuza Jooyuza commented Oct 9, 2024

fock_combinations has large memory usage and low efficiency when nmode and nphoton are large. This PR is trying to enhance its performance when a small cutoff is indicated.

image

@sansiro77 sansiro77 self-requested a review October 9, 2024 07:48
@sansiro77 sansiro77 self-assigned this Oct 9, 2024
@sansiro77 sansiro77 added the enhancement New feature or request label Oct 9, 2024
Copy link
Contributor

@sansiro77 sansiro77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@sansiro77 sansiro77 merged commit d5f3fbd into TuringQ:main Oct 9, 2024
@Jooyuza Jooyuza deleted the feature_combinations branch October 22, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants