Feature/vector #3
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create License
Pull Request Test Coverage Report for Build 30
💛 - Coveralls |
TusharChugh
requested changes
Nov 8, 2018
Owner
TusharChugh
left a comment
TusharChugh
left a comment
There was a problem hiding this comment.
Added suggestions to improve the code
include/vector/Vector.h
Outdated
| #include <list> | ||
| #include <memory> | ||
| /* | ||
| template< |
include/vector/Vector.h
Outdated
| // constructor, and deconstruct, copy constructor, move constructor | ||
| //vector | ||
| explicit Vector(); | ||
| explicit Vector(size_t count, const T &value); // assign value into the "count" elements |
Owner
There was a problem hiding this comment.
Add default values to the constructor
include/vector/Vector.h
Outdated
| // what we want to achieve? | ||
| // constructor, and deconstruct, copy constructor, move constructor | ||
| //vector | ||
| explicit Vector(); |
Owner
There was a problem hiding this comment.
Remove this default constructor after adding default value to the other
include/vector/Vector.h
Outdated
| const Vector_iterator end() const noexcept{ | ||
| return Vector_iterator(this, _count); | ||
| } | ||
|
|
include/vector/Vector.h
Outdated
| Vector_iterator(const Vector_iterator&); //Vector_iterator(p), use the Vector_iterator to initialize this iterator | ||
| Vector_iterator(const Vector<T>*, size_t index); //Vector_iterator(p, size_t index), p---> move 'index' position; | ||
|
|
||
| // iterator behavior, TDD, to think it thoroughly before writing the member functions |
include/vector/Vector.h
Outdated
| // constructor for iterator, fot tdd | ||
| Vector_iterator(); | ||
| Vector_iterator(const Vector_iterator&); //Vector_iterator(p), use the Vector_iterator to initialize this iterator | ||
| Vector_iterator(const Vector<T>*, size_t index); //Vector_iterator(p, size_t index), p---> move 'index' position; |
Owner
There was a problem hiding this comment.
add default value to the index
include/vector/Vector.h
Outdated
| // } | ||
| // }; | ||
| template<class T> | ||
| Vector<T>::Vector():_count(0),_capacity(0){ |
Owner
There was a problem hiding this comment.
remove magic numbers from the code
include/vector/Vector.h
Outdated
| } | ||
|
|
||
|
|
||
| //Implementation: copy constructor and assignment operator |
Owner
There was a problem hiding this comment.
remove code which is not useful
include/vector/Vector.h
Outdated
| reserve(other._capacity); | ||
| for (auto index = 0; index != other.size(); ++index) { | ||
| _elements[index] = other._elements[index]; | ||
| _count++; |
| @@ -0,0 +1,139 @@ | |||
| #include"vector/Vector.h" | |||
Owner
There was a problem hiding this comment.
move different kind of test cases in different files. Use setup and tear down from gtest https://github.com/google/googletest/blob/master/googletest/docs/primer.md
TusharChugh
approved these changes
Nov 12, 2018
Owner
|
Merged vector |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the vector implemention