Skip to content

Conversation

@qizhangncs
Copy link
Collaborator

add queue implementation

@coveralls
Copy link

coveralls commented Nov 15, 2018

Pull Request Test Coverage Report for Build 41

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 95.183%

Totals Coverage Status
Change from base Build 39: 0.3%
Covered Lines: 415
Relevant Lines: 436

💛 - Coveralls

queue(queue&& other):_container(std::move(other._container)){};

queue& operator = (const queue& other){
this->_container = other._container;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no this required here

Copy link
Owner

@TusharChugh TusharChugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the requested changes


public:
queue(): queue(Container()){};// default constuct

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add default destructor

queue(queue&& other):_container(std::move(other._container)){};

queue& operator = (const queue& other){
this->_container = other._container;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no this required here

@TusharChugh TusharChugh merged commit b73dd21 into TusharChugh:master Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants