-
Notifications
You must be signed in to change notification settings - Fork 1
add queue implementation #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add queue implementation #8
Conversation
include/queue/Queue.h
Outdated
| queue(queue&& other):_container(std::move(other._container)){}; | ||
|
|
||
| queue& operator = (const queue& other){ | ||
| this->_container = other._container; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no this required here
TusharChugh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the requested changes
|
|
||
| public: | ||
| queue(): queue(Container()){};// default constuct | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add default destructor
include/queue/Queue.h
Outdated
| queue(queue&& other):_container(std::move(other._container)){}; | ||
|
|
||
| queue& operator = (const queue& other){ | ||
| this->_container = other._container; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no this required here
add queue implementation