Skip to content
This repository was archived by the owner on Nov 9, 2020. It is now read-only.

Conversation

@ljacqu
Copy link

@ljacqu ljacqu commented Dec 9, 2019

Tried to merge the parent repo's master into the gson branch to the best of my abilities. I undid some of the minor formatting changes that were done in gson that make merging more difficult. Most changes of that type are in the last commit, so we could also talk about merging this branch without the last commit.

wesrice and others added 30 commits August 20, 2018 19:55
Add condition to only run `snyk monitor` once on `master`
Ensure Snyk only runs if `$SNYK_TOKEN` exists
Upgrade `com.fasterxml.jackson.core:jackson-databind` artifact
Update jackson dep to 2.9.8 to address upstream security fix
Update to latest jackson-databind to address CVEs
Bump jackson-databind version to address CVEs
Bump jackson-databind version to address CVEs
Many of these are just code modernizations as we now require Java 7.
oschwald and others added 21 commits October 2, 2019 14:53
With Java 7 try-with-resource statement.
Add ability to get record associated with lookup
Update README.md and CHANGELOG.md for network changes
Bumps [exec-maven-plugin](https://github.com/mojohaus/exec-maven-plugin) from 1.1 to 1.6.0.
- [Release notes](https://github.com/mojohaus/exec-maven-plugin/releases)
- [Commits](mojohaus/exec-maven-plugin@exec-maven-plugin-1.1...exec-maven-plugin-1.6.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps maven-gpg-plugin from 1.4 to 1.6.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [maven-source-plugin](https://github.com/apache/maven-source-plugin) from 2.2.1 to 3.1.0.
- [Release notes](https://github.com/apache/maven-source-plugin/releases)
- [Commits](apache/maven-source-plugin@maven-source-plugin-2.2.1...maven-source-plugin-3.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
…e.maven.plugins-maven-compiler-plugin-3.8.1

Bump maven-compiler-plugin from 3.1 to 3.8.1
…aus.mojo-versions-maven-plugin-2.7

Bump versions-maven-plugin from 2.2 to 2.7
…aus.mojo-exec-maven-plugin-1.6.0

Bump exec-maven-plugin from 1.1 to 1.6.0
…e.maven.plugins-maven-gpg-plugin-1.6

Bump maven-gpg-plugin from 1.4 to 1.6
…e.maven.plugins-maven-source-plugin-3.1.0

Bump maven-source-plugin from 2.2.1 to 3.1.0
Bumps [maven-source-plugin](https://github.com/apache/maven-source-plugin) from 3.1.0 to 3.2.0.
- [Release notes](https://github.com/apache/maven-source-plugin/releases)
- [Commits](apache/maven-source-plugin@maven-source-plugin-3.1.0...maven-source-plugin-3.2.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
…e.maven.plugins-maven-source-plugin-3.2.0

Bump maven-source-plugin from 3.1.0 to 3.2.0
…gson

# Conflicts:
#	README.md
#	pom.xml
#	src/main/java/com/maxmind/db/Decoder.java
#	src/main/java/com/maxmind/db/NodeCache.java
#	src/main/java/com/maxmind/db/Reader.java
#	src/main/java/com/maxmind/db/package-info.java
#	src/test/java/com/maxmind/db/DecoderTest.java
#	src/test/java/com/maxmind/db/MultiThreadedTest.java
#	src/test/java/com/maxmind/db/ReaderTest.java
- Hopefully makes future merges a little easier
@TuxCoding
Copy link
Owner

Maybe I should do only minimal changes next time. Sorry for that additional work.

@TuxCoding TuxCoding self-requested a review December 13, 2019 13:18
Copy link
Owner

@TuxCoding TuxCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@TuxCoding TuxCoding merged commit 9ead508 into TuxCoding:gson Dec 13, 2019
@ljacqu
Copy link
Author

ljacqu commented Dec 13, 2019

Thanks for looking at it!

Sorry for that additional work.

Nothing to be sorry about—all the improvements you did I would agree with if we didn't have to "orient" ourselves towards another repo :)

@ljacqu ljacqu deleted the maxmind-master-to-gson-branch- branch December 13, 2019 19:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants