This repository was archived by the owner on Aug 15, 2024. It is now read-only.
Fix referSip code samples. #859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 1, 2021 16:29
`referSip` methods were deprecated; code samples should be updated to reflect this. These code samples were automatically generated with the Twilio twiml generator (https://github.com/TwilioDevEd/twiml-generator).
The twiml generator script added these unnecessary imports.
craigsdennis
approved these changes
Feb 3, 2021
| const refer = response.refer({ | ||
| 'action': '/handleRefer', | ||
| 'method': 'POST' | ||
| action: '/handleRefer', |
There was a problem hiding this comment.
Interesting...did you change this or did the formatting change?
Contributor
Author
There was a problem hiding this comment.
This as an automated formatting change
| public static void main(String[] args) { | ||
| ReferSip sip = new ReferSip.Builder("sip:alice@example.com").build(); | ||
| Refer refer = new Refer.Builder().action("/handleRefer").method(HttpMethod.POST).referSip(number).build(); | ||
| Refer refer = new Refer.Builder().action("/handleRefer").method(HttpMethod.POST).sip(sip).build(); |
There was a problem hiding this comment.
Interesting the typing here is different than the C# use case, but unrelated to this PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
referSipmethods were deprecated; code samples should be updated to reflect this.(Context from the
twilio-javalibrary: https://github.com/twilio/twilio-java/blob/main/UPGRADE.md#changed---renamed-nested-twiml-methods)These code samples were automatically generated and verified with the Twilio twiml generator (https://github.com/TwilioDevEd/twiml-generator).