chore: Remove checksum/tlsAlternativeNames from deployment template#122
Merged
clement0010 merged 1 commit intomasterfrom Aug 29, 2025
Merged
chore: Remove checksum/tlsAlternativeNames from deployment template#122clement0010 merged 1 commit intomasterfrom
checksum/tlsAlternativeNames from deployment template#122clement0010 merged 1 commit intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the checksum/tlsAlternativeNames annotation from the Gateway deployment template to prevent unnecessary pod restarts when TLS secrets change, following the implementation of TLS certificate hot-reload functionality.
- Removes
checksum/tlsAlternativeNamesannotation from deployment template - Updates corresponding test cases and snapshots to reflect the removed annotation
- Ensures pod annotations structure remains intact when user-defined
podAnnotationsare present
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| deploy/gateway/templates/deployment.yaml | Removes the checksum annotation and restructures annotations block |
| deploy/gateway/tests/deployment_test.yaml | Removes test case that verified the checksum annotation |
| deploy/gateway/tests/snapshot/snapshot_test.yaml.snap | Updates test snapshot to match removed annotation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
minhtule
added a commit
that referenced
this pull request
Dec 30, 2025
## Changes Change config structure in `config.yaml` according to [the latest spec](https://www.notion.so/twingate/Gateway-configuration-Helm-deployment-and-k8s-operator-integration-2933476dd039801ca754c589152c67a7?source=copy_link#2943476dd03980399ab9cbf694f05332) - Add L7 application protocol properties at the root level + `kubernetes`: Kubernetes upstreams are defined here. + `ssh`: SSH config and upstreams are defined here. - Rename `downstream` → `server` and `upstream` → `client` config properties to avoid confusion with `upstreams` property. - Remove the root `upstreams` properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
checksum/tlsAlternativeNamesfromdeployment.yamltemplate to avoid restarting the Gateway pod when the TLS secret changes