chore: Add unit suffix to ptyReq and windowChangeReq terminal size variable fields#175
Merged
clement0010 merged 1 commit intomasterfrom Jan 5, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR renames the terminal size fields in ptyReq and windowChangeReq structs to include explicit unit suffixes, improving code clarity per RFC4254 specification. The field names now clearly distinguish between character-based dimensions (columns/rows) and pixel-based dimensions.
- Renamed
Columns/RowstoWidthColumns/HeightRows(character-based dimensions) - Renamed
Width/HeighttoWidthPixels/HeightPixels(pixel-based dimensions) - Updated all references across implementation and test files
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/sshhandler/request_handler.go | Updated struct definitions for ptyReq and windowChangeReq with explicit unit suffixes |
| internal/sshhandler/request_handler_test.go | Updated test helper functions and assertions to use new field names |
| internal/sshhandler/channel_pair.go | Updated implementation code to reference new field names when handling pty and window-change requests |
| internal/sshhandler/channel_pair_test.go | Updated test data to use new field names in mock request payloads |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
minhtule
approved these changes
Jan 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
ptyReqandwindowChangeReqterminal size variable fields to make units explicit per RFC4254