chore: Fix pre-release Helm chart version#181
Merged
Conversation
minhtule
requested review from
clement0010,
Copilot and
ekampf
and removed request for
clement0010
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modifies the pre-release version format to ensure compatibility with OCI registry tag requirements. The change replaces the SemVer build metadata separator (+) with a hyphen (-) in dev tags, transforming versions from 0.12.1-dev+ca27a29 to 0.12.1-dev-ca27a29.
Changes:
- Modified the Makefile to generate dev tags with hyphen-separated commit hash instead of using SemVer metadata format
- Removed unnecessary
replacefunction calls from.goreleaser.yamlsince version strings no longer contain+character
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Makefile | Updated cut-release-dev target to generate pre-release tags with hyphen-separated git commit hash |
| .goreleaser.yaml | Removed all replace .Version "+" "-" template function calls from Docker image and manifest templates |
Comments suppressed due to low confidence (1)
.goreleaser.yaml:13
- The snapshot version template still uses the
+character for build metadata. This will cause OCI compatibility issues when building snapshots (e.g., during CI builds). Consider updating this to use a hyphen instead:'{{ .Version }}-{{envOrDefault "VERSION_PRERELEASE" "local"}}-{{ .ShortCommit }}'
version_template: '{{ .Version }}-{{envOrDefault "VERSION_PRERELEASE" "local"}}+{{ .ShortCommit }}'
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
minhtule
force-pushed
the
feat/mt/fix-dev-helm-chart-version
branch
from
7640208 to
678928d
Compare
ekampf
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Change the Git tag for dev (prerelease) version from
0.12.1-dev+ca27a29to0.12.1-dev-ca27a29, which is still a valid semantic version, to be compatible with OCI tag format.Notes
While Helm chart version supports full semantic versioning (doc), our Helm charts are distributed via OCI-based Github registry. OCI tag doesn't allow the
+character (spec) so installing our Helm chart would run into issues likeA tag with
+would also cause issues with dependabot for Helm charts.