Skip to content

chore: Upgrade golangci-lint to v2.8#188

Merged
ekampf merged 1 commit intomasterfrom
feat/mt/fix-golangci-lint
Feb 6, 2026
Merged

chore: Upgrade golangci-lint to v2.8#188
ekampf merged 1 commit intomasterfrom
feat/mt/fix-golangci-lint

Conversation

@minhtule
Copy link
Copy Markdown
Contributor

@minhtule minhtule commented Feb 6, 2026

Changes

  • Upgrade golangci-lint to v2.8
  • Disable new linter prealloc. golangci-lint doesn't recommend to turn on this linter (doc). All violations are in test anyway.
    # IMPORTANT: we don't recommend using this linter before doing performance profiling.
    # For most programs usage of prealloc will be a premature optimization.
    

@coveralls
Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 21736096174

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.956%

Totals Coverage Status
Change from base Build 21596693531: 0.0%
Covered Lines: 2722
Relevant Lines: 3204

💛 - Coveralls

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the golangci-lint version used in CI from v2.6 to v2.8 and disables the prealloc linter based on official golangci-lint recommendations that it should not be enabled without performance profiling.

Changes:

  • Upgrade golangci-lint version to v2.8 in CI workflow
  • Add prealloc to the list of disabled linters with explanatory comment

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/ci.yaml Updates golangci-lint version from v2.6 to v2.8
.golangci.yml Adds prealloc linter to disabled list with justification comment

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ekampf ekampf merged commit 1b03cec into master Feb 6, 2026
18 checks passed
@ekampf ekampf deleted the feat/mt/fix-golangci-lint branch February 6, 2026 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants