feat: Support Vault AppRole authentication method#190
Merged
clement0010 merged 12 commits intomasterfrom Feb 25, 2026
Merged
Conversation
Collaborator
Pull Request Test Coverage Report for Build 22356474081Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Vault AppRole authentication support for the SSH CA Vault integration, along with config schema/validation updates to allow either a static token, AppRole credentials, or implicit VAULT_TOKEN usage.
Changes:
- Add Vault AppRole login support when
ssh.ca.vault.auth.appRoleis configured. - Add config types + validation for
ssh.ca.vault.authandssh.ca.vault.auth.appRole. - Add
go.mod/go.sumdependency forgithub.com/hashicorp/vault/api/auth/approle.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/sshhandler/ca.go | Adds AppRole authentication flow during Vault client initialization. |
| internal/config/config.go | Extends Vault auth config schema and adds validation for token vs AppRole. |
| internal/config/config_test.go | Adds unit tests for new auth config validation and AppRole mount defaulting. |
| go.mod | Adds AppRole auth submodule dependency. |
| go.sum | Adds checksums for the new dependency. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
clement0010
force-pushed
the
feat/support-vault-approle-authn-method
branch
from
62f4c22 to
b47a3a0
Compare
clement0010
force-pushed
the
feat/support-vault-approle-authn-method
branch
2 times, most recently
from
9e0ad29 to
2361dc4
Compare
clement0010
force-pushed
the
feat/support-vault-approle-authn-method
branch
from
2361dc4 to
eaf3b25
Compare
clement0010
commented
Feb 19, 2026
| return nil, fmt.Errorf("failed to create vault client: %w", err) | ||
| } | ||
|
|
||
| client.SetNamespace(vaultConfig.Namespace) |
Contributor
Author
There was a problem hiding this comment.
We should set the namespace before auth to ensure the login request and all subsequent vault requests hit the same namespace.
clement0010
added a commit
that referenced
this pull request
Mar 5, 2026
~⚠️ Branched off from #190~ ## Changes - Create a new `VaultClient` type that wraps the Vault API client with token lifecycle management that watches token expiry, re-authenticates on failure, and retries login. - Start Vault client token renewal loop in `SSHProxy.Start()`, so we can gracefully shut down the token lifecycle loop as SSHProxy terminates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
newVaultAuthMethodto return the appropriate authMethod based on the gateway configAppRoleauthentication methodnewVaultClientto return authenticated Vault clientssh.vault.auth.approleconfiguration and validationNotes
Support for token renewal will be added on a separate PR.