Skip to content

feat: Add public key fallback for SSH host key negotiation#224

Merged
clement0010 merged 1 commit intomasterfrom
feat/support-non-cert-based-host-key
Mar 10, 2026
Merged

feat: Add public key fallback for SSH host key negotiation#224
clement0010 merged 1 commit intomasterfrom
feat/support-non-cert-based-host-key

Conversation

@clement0010
Copy link
Copy Markdown
Contributor

@clement0010 clement0010 commented Mar 9, 2026

Changes

  • Register the gateway's public key as a fallback host key in GetDownstreamConfig, alongside the existing certificate-based host key
  • Allows SSH clients that don't support certificate-based host key algorithms (e.g. Claude Desktop) to connect using public key verification

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.39%. Comparing base (b61a9ec) to head (9d914dd).
⚠️ Report is 3 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
+ Coverage   82.26%   82.39%   +0.12%     
==========================================
  Files          35       35              
  Lines        2532     2533       +1     
==========================================
+ Hits         2083     2087       +4     
+ Misses        341      337       -4     
- Partials      108      109       +1     
Flag Coverage Δ
integration 48.38% <100.00%> (+0.06%) ⬆️
unit 78.20% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
internal/sshhandler/config.go 79.10% <100.00%> (+0.15%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@clement0010 clement0010 requested a review from minhtule March 9, 2026 07:06
Copy link
Copy Markdown
Contributor

@minhtule minhtule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@clement0010 clement0010 merged commit 7103c31 into master Mar 10, 2026
14 checks passed
@clement0010 clement0010 deleted the feat/support-non-cert-based-host-key branch March 10, 2026 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants