Skip to content

fix: Windows CI#41

Merged
liorr merged 2 commits intomainfrom
feature/lr/fix_windows_build_timeout
Jun 7, 2025
Merged

fix: Windows CI#41
liorr merged 2 commits intomainfrom
feature/lr/fix_windows_build_timeout

Conversation

@liorr
Copy link
Contributor

@liorr liorr commented Jun 7, 2025

The main fix of the PR is updating the PowerShell web request command with a basic parsing option, as without it, the parsing would halt the job.

I've also added job-specific timeouts for Ubuntu and Windows runners to ensure that the jobs don't run indefinitely.

@liorr liorr requested a review from Copilot June 7, 2025 14:58

This comment was marked as outdated.

@liorr liorr requested a review from Copilot June 7, 2025 15:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to fix Windows CI issues by updating the workflow configuration. Key changes include:

  • Adding job-specific timeouts for Ubuntu and Windows runners.
  • Updating the PowerShell web request command with a timeout and basic parsing option.
Comments suppressed due to low confidence (3)

.github/workflows/ci.yaml:27

  • Verify that a 3-minute timeout is sufficient for the Ubuntu job workload. If jobs tend to run longer, consider adjusting this value.
timeout-minutes: 3

.github/workflows/ci.yaml:97

  • Ensure that a 6-minute timeout is appropriate for the Windows job, particularly under heavy CI load. Adjust if necessary to avoid premature job terminations.
timeout-minutes: 6

.github/workflows/ci.yaml:117

  • Confirm that a 10-second timeout for Invoke-WebRequest is adequate for expected network latency. Additionally, review whether -UseBasicParsing is the best choice given the PowerShell version in use.
Invoke-WebRequest -Uri $env:TEST_URL -Verbose -TimeoutSec 10 -UseBasicParsing

@liorr liorr merged commit a5e263d into main Jun 7, 2025
9 checks passed
@liorr liorr deleted the feature/lr/fix_windows_build_timeout branch June 7, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants