🟡 I-1: verify-plugin.sh assertion broken — schema count 6 vs hardcoded 5

[ComBba]

Priority: 🟡 Important
Audit source: T4 Leader (devops-architect)
Related PR: v1.11.0 (PR #54 or earlier schema addition)

Problem

Running scripts/verify-plugin.sh on main is currently failing.

Evidence

$ bash scripts/verify-plugin.sh
...
✗ schemas: 6 (expected 5)
...
=== SUMMARY ===
Pass: 56
Fail: 1

File: near scripts/verify-plugin.sh:131 — the schema count assertion is hardcoded to -eq 5, but v1.11.0 added a 6th schema.

Side effects

• DoD promised the pass count would grow from 56 → 70+
• Reality: still 56, plus 1 broken assertion
• That is, the v1.11.0 PR was merged while ignoring verify-plugin verification (CI gating likely does not mark this script as required)

Acceptance Criteria

• Fix the assertion near scripts/verify-plugin.sh:131: use expected_schemas=6 or a dynamic count
• Add a helper function so hardcoded assertion counts auto-sync:

  count_files() { find "$1" -name "$2" | wc -l | tr -d ' '; }
  EXPECTED_SCHEMAS=$(count_files "$PLUGIN_DIR/schemas" "*.schema.json")
  # ... assertions should only check the invariant ("schema count has not drifted abnormally")

• Confirm .github/workflows/ci.yml gates on the verify-plugin result with fail-on-error (add it if not already enforced)
• Audit the DoD pass count 70+ promise — confirm whether it grew naturally from new fixtures/assets, then update the expected number

Notes

A trivial fix (1-line change), but the real concern is that main is partially broken — CI gating policy needs review.

Cross-references

• T-1 (advocate count assertion) — same pattern
• C-1 (missing e2e verification) — the assertions themselves are stale

[sgwannabe]

Closed by PR #83 — fix: hygiene bundle — verify-plugin schema count + idea_summary cap + macOS dup gitignore (#63 #65 #68)