Skip to content

fix(commands): translate /pf:help body to English (narrow partial #113)#118

Merged
ComBba merged 1 commit intomainfrom
fix/113-help-only
Apr 26, 2026
Merged

fix(commands): translate /pf:help body to English (narrow partial #113)#118
ComBba merged 1 commit intomainfrom
fix/113-help-only

Conversation

@ComBba
Copy link
Copy Markdown
Contributor

@ComBba ComBba commented Apr 26, 2026

Summary

Narrows the original #113 scope to a single file: plugins/preview-forge/commands/help.md. This is the one command whose Korean prose actually leaks into user-visible output (per the bug report screenshot of /pf:help in the issue body). The other 14 command bodies stay Korean for now and are deferred to a follow-up PR with proper behavioral regression coverage.

Why narrowed (risk argument)

Each commands/*.md body is loaded by Claude Code as a system prompt when its slash command runs. Translating prose changes the system prompt, which can change Claude's behavior in subtle ways (different reasoning, different tool calls, different output formatting). There is no end-to-end behavioral test suite for these commands today, so a 15-file translation lands with no rollback signal short of manual e2e testing per command.

Meanwhile, Layer-0 Rule 10 (Output language: English, in plugins/preview-forge/methodology/global.md) already enforces English output regardless of command-body language. So the visible-Korean-leak surface for the 14 non-help commands is near zero.

Marginal benefit of translating the 14 remaining commands: small. Marginal risk: real. Decision: ship the one file that actually has a user-visible leak (/pf:help rendering Korean tables per the original screenshot), defer the rest.

Resolves

Partially closes #113. The issue stays open for a follow-up PR that translates the remaining 13 command bodies after end-to-end behavioral testing.

Changes

plugins/preview-forge/commands/help.md:

  • Translated all Korean prose to English. Frontmatter, code fences, command examples, file paths, env-var names preserved verbatim.
  • "What's new" section bumped from v1.10.0 to v1.14.1 — now lists v1.11 / v1.12 / v1.13 / v1.14 entries.
  • Command count corrected from 14 to 15 (matches the /pf:preview slash command added in v1.13).
  • Added a maintenance pointer at the end of "What's new": This section is regenerated each release; see CHANGELOG.md for the canonical per-tag mapping.

Test plan

  • bash scripts/verify-plugin.sh passes locally (59/59)
  • Hangul (U+AC00–U+D7A3) sweep on help.md returns 0 characters
  • Frontmatter unchanged (compared against git show origin/main:plugins/preview-forge/commands/help.md)
  • Behavior-affecting fields untouched (description in frontmatter, model, tools list)
  • CI green on PR

Notes for reviewers

The original #113-scope PR (#117) was closed in favor of this narrowed PR. The rationale is documented in #117's close comment and in the commit body of edaac42.

The remaining 13 command bodies (Korean) are tracked under #113. A follow-up PR can translate them once we have behavioral regression coverage — at that point the risk of subtle prompt drift is bounded.

Scope narrowed from the original #113 to just commands/help.md, the
only command whose Korean prose actually leaks into user-visible
output (per the original bug report screenshot). The other 14
command files stay Korean for now — Layer-0 Rule 10 in
methodology/global.md already enforces English output regardless of
command-body language, so the visible-leak surface for those is
nearly zero, and translating them carries non-trivial behavior-change
risk (each body acts as a system prompt for Claude when its slash
command runs, with no end-to-end behavioral test suite to catch
subtle drift).

Also updates the help.md "What's new" section that was frozen at
v1.10.0 — now covers v1.11 (defense-in-depth + regex hardening),
v1.12 (cinematic preview + auto-rec + reference example), v1.13
(H1 → SpecDD auto-advance, H2 → preview-server auto-launch,
new /pf:preview), v1.14 (Rule 10 + default-profile fix). The
section ends with a maintenance pointer to CHANGELOG.md so future
releases get reflected without ad-hoc edits.

The "14 commands" count in help.md is corrected to 15 (matches the
v1.13 addition of /pf:preview).

Layer-0 Rule 10 enforcement, single-file change, low blast radius.

#113 stays open for a follow-up that translates the remaining 13
command bodies after a proper behavioral regression pass.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 26, 2026

Warning

Rate limit exceeded

@ComBba has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 9 minutes and 38 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 9 minutes and 38 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 53eed114-c8da-449e-91b8-456849c6dd4a

📥 Commits

Reviewing files that changed from the base of the PR and between f91571e and edaac42.

📒 Files selected for processing (1)
  • plugins/preview-forge/commands/help.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/113-help-only

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ComBba ComBba merged commit 6957022 into main Apr 26, 2026
7 checks passed
@ComBba ComBba deleted the fix/113-help-only branch April 26, 2026 20:03
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request translates the help.md documentation for the preview-forge plugin from Korean to English and updates the "What's new" section to reflect changes through version 1.14.1. Review feedback identifies several documentation inconsistencies, including a reference to a non-existent FAQ section, mismatches between the version descriptions and the plugin's changelog, and an incorrect relative path for the changelog link.

## Behavior

14 명령어 요약 + 자주 묻는 질문 (FAQ).
Summary of the 15 commands plus a frequently asked questions (FAQ) section.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The behavior description mentions a "frequently asked questions (FAQ) section", but no such section exists in this file. Additionally, while the command count is correctly updated to 15 here, plugins/preview-forge/README.md still references "14 slash commands" (line 13). Documentation designated as an authoritative source must be free of errors to maintain credibility and trustworthiness.

Suggested change
Summary of the 15 commands plus a frequently asked questions (FAQ) section.
Summary of the 15 commands.
References
  1. Documentation designated as an 'authoritative source' must be free of errors, including typos, to maintain its credibility and trustworthiness.

Comment on lines +23 to +25
## What's new (through semver v1.14.1)

> "v1.6 audit" · "v1.7 audit"ComBba feature umbrella 이름이고, 실제 release tag는 release-please가 Conventional Commits로 자동 부여한 v1.6.0·v1.10.0 등 semver. 자세한 매핑은 [CHANGELOG.md](../../../CHANGELOG.md) 참조.
> "v1.6 audit" / "v1.7 audit" are ComBba feature umbrella names; the actual release tags are the semver values that release-please assigns from Conventional Commits (v1.6.0, v1.10.0, v1.14.1, and so on). For the per-tag mapping see [CHANGELOG.md](../../../CHANGELOG.md).
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There are several inconsistencies between this section and the plugins/preview-forge/CHANGELOG.md:

  1. Version Mismatch: The changelog currently ends at 1.11.0, but this file references v1.14.1 as a completed release.
  2. Content Mismatch: The description for v1.11 here ("Defense-in-depth + regex hardening") does not match the changelog entry for 1.11.0 ("Phase 8 — Requirements Expansion"). Per repository rules, explicitly document the mapping between internal feature names (like 'Phase 8') and semantic versioning tags to prevent confusion.
  3. Changelog Link: The link points to the root CHANGELOG.md (../../../CHANGELOG.md), but the plugin-specific plugins/preview-forge/CHANGELOG.md (../CHANGELOG.md) contains the detailed feature umbrella mappings mentioned in the text. Consider linking to the plugin-specific changelog instead.
References
  1. To prevent confusion from versioning inconsistencies, explicitly document the distinction between internal feature/audit names and the final semantic versioning tags, and clarify their mapping in relevant documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(commands): all 15 /pf:* slash command bodies in Korean + /pf:help "What's new" stuck at v1.10.0 (must reach v1.14.1 + maintenance process)

1 participant