feat: add nodeview props in reactinline contentspec #1578
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wststone is attempting to deploy a commit to the TypeCell Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few additional props to align feature parity between Tiptap and BlockNote's inline content handling.
While migrating from Tiptap to BlockNote, I encountered a few missing features that were previously supported in Tiptap. Specifically, some custom extensions relied on the
getPosandnodeprops that weren’t available in BlockNote'screateReactInlineContentSpec'srenderfunction.This PR makes smoother migration paths from previous Tiptap users and achieve feature parity.