fix: add preload option to video blocks #2229
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2203
Rationale
With this fix, it's possible to set a
preloadoption in the config of your video block in the schema.I think this is cleaner than setting it on a block prop (as "preload" seems a UI concern, that something that should be stored in the document). The downside is that it's a single configuration that applies to all blocks
Changes
x
Impact
x
Testing
manual
Screenshots/Video
x
Checklist
Additional Notes