Skip to content

fix: filter out invalid heading items based on the current block schema in the slash menu #2253 #2259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nperez0111 merged 1 commit into from
Dec 11, 2025
Merged

fix: filter out invalid heading items based on the current block schema in the slash menu #2253 #2259

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
108 changes: 40 additions & 68 deletions packages/core/src/extensions/SuggestionMenu/getDefaultSlashMenuItems.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,41 +89,24 @@ export function getDefaultSlashMenuItems<
const items: DefaultSuggestionItem[] = [];

if (editorHasBlockWithType(editor, "heading", { level: "number" })) {
items.push(
{
onItemClick: () => {
insertOrUpdateBlockForSlashMenu(editor, {
type: "heading",
props: { level: 1 },
});
},
badge: formatKeyboardShortcut("Mod-Alt-1"),
key: "heading",
...editor.dictionary.slash_menu.heading,
},
{
onItemClick: () => {
insertOrUpdateBlockForSlashMenu(editor, {
type: "heading",
props: { level: 2 },
});
},
badge: formatKeyboardShortcut("Mod-Alt-2"),
key: "heading_2",
...editor.dictionary.slash_menu.heading_2,
},
{
onItemClick: () => {
insertOrUpdateBlockForSlashMenu(editor, {
type: "heading",
props: { level: 3 },
});
},
badge: formatKeyboardShortcut("Mod-Alt-3"),
key: "heading_3",
...editor.dictionary.slash_menu.heading_3,
},
);
(editor.schema.blockSchema.heading.propSchema.level.values || [])
.filter((level): level is 1 | 2 | 3 => level <= 3)
.forEach((level) => {
items.push({
onItemClick: () => {
insertOrUpdateBlockForSlashMenu(editor, {
type: "heading",
props: { level: level },
});
},
badge: formatKeyboardShortcut(`Mod-Alt-${level}`),
key:
level === 1 ? ("heading" as const) : (`heading_${level}` as const),
...editor.dictionary.slash_menu[
level === 1 ? ("heading" as const) : (`heading_${level}` as const)
],
});
});
}

if (editorHasBlockWithType(editor, "quote")) {
Expand Down Expand Up @@ -316,39 +299,27 @@ export function getDefaultSlashMenuItems<
isToggleable: "boolean",
})
) {
items.push(
{
onItemClick: () => {
insertOrUpdateBlockForSlashMenu(editor, {
type: "heading",
props: { level: 1, isToggleable: true },
});
},
key: "toggle_heading",
...editor.dictionary.slash_menu.toggle_heading,
},
{
onItemClick: () => {
insertOrUpdateBlockForSlashMenu(editor, {
type: "heading",
props: { level: 2, isToggleable: true },
});
},

key: "toggle_heading_2",
...editor.dictionary.slash_menu.toggle_heading_2,
},
{
onItemClick: () => {
insertOrUpdateBlockForSlashMenu(editor, {
type: "heading",
props: { level: 3, isToggleable: true },
});
},
key: "toggle_heading_3",
...editor.dictionary.slash_menu.toggle_heading_3,
},
);
(editor.schema.blockSchema.heading.propSchema.level.values || [])
.filter((level): level is 1 | 2 | 3 => level <= 3)
.forEach((level) => {
items.push({
onItemClick: () => {
insertOrUpdateBlockForSlashMenu(editor, {
type: "heading",
props: { level: level, isToggleable: true },
});
},
key:
level === 1
? ("toggle_heading" as const)
: (`toggle_heading_${level}` as const),
...editor.dictionary.slash_menu[
level === 1
? ("toggle_heading" as const)
: (`toggle_heading_${level}` as const)
],
});
});
}

if (editorHasBlockWithType(editor, "heading", { level: "number" })) {
Expand All @@ -362,6 +333,7 @@ export function getDefaultSlashMenuItems<
props: { level: level },
});
},
badge: formatKeyboardShortcut(`Mod-Alt-${level}`),
key: `heading_${level}`,
...editor.dictionary.slash_menu[`heading_${level}`],
});
Expand Down
Loading