fix: deep merge floatingUIOptions to preserve internal settings #2310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ellOS#2308 Use lodash.merge instead of spread operator to properly merge nested floatingUIOptions properties. This prevents user-provided options like `useFloatingOptions: { strategy: "fixed" }` from overwriting internal settings such as `open`, `onOpenChange`, `placement`, and `middleware`.
|
@ysds is attempting to deploy a commit to the TypeCell Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Deep merge
floatingUIOptionsto preserve internal settings when custom options are passed.Rationale
Closes #2308
Changes
lodash.mergeinstead of spread operator for deep mergingfloatingUIOptionsin all controller componentssatisfies FloatingUIOptionsto the first argument ofmerge()to maintain type inference for callback parameters (e.g.,onOpenChange)Impact
Users can now pass partial
floatingUIOptionswithout losing the controller's internal default settings.Testing
Build passes.
Screenshots/Video
Checklist
Additional Notes