feat: Enter moves selection to cell below in tables (BLO-1006) by matthewlipski · Pull Request #2685 · TypeCellOS/BlockNote

matthewlipski · 2026-04-28T14:16:05Z

Summary

This PR makes Enter move the selection to the cell below in a table much as Tab moves it to the cell right. Shift+Enter still creates a hard break as before.

Closes #2409

Rationale

This is more similar to how table keyboard navigation typically works in other apps.

Changes

See above.

Impact

N/A

Testing

Added e2e tests.

Screenshots/Video

N/A

Checklist

Code follows the project's coding standards.
Unit tests covering the new feature have been added.
All existing tests pass.
The documentation has been updated to reflect the new feature

Additional Notes

N/A

Summary by CodeRabbit

New Features
- Enter now moves focus to the cell below when editing tables.
- Shift+Enter inserts a new line inside the current table cell without moving focus.
Tests
- Added end-to-end tests covering Enter and Shift+Enter table behavior.
- Added cross-browser snapshot fixtures validating expected table document states.

vercel · 2026-04-28T14:16:11Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
blocknote	Ready	Preview	Apr 28, 2026 2:58pm
blocknote-website	Ready	Preview	Apr 28, 2026 2:58pm

coderabbitai · 2026-04-28T14:16:22Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 19570450-b878-498f-8f31-968b6b3b0fc3

📥 Commits

Reviewing files that changed from the base of the PR and between 664328a and bfc12e1.

📒 Files selected for processing (1)

packages/core/src/blocks/Table/TableExtension.ts

📝 Walkthrough

Walkthrough

Changes modify Enter/Shift+Enter behavior in table cells: Enter now moves the cursor to the cell below (if present) via table navigation utilities; Shift+Enter inserts a hard line break inside the current cell. End-to-end Playwright tests and JSON snapshots for Chromium, Firefox, and WebKit were added.

Changes

Cohort / File(s)	Summary
Core Table Logic `packages/core/src/blocks/Table/TableExtension.ts`	Replaces prior Enter handling that inserted `hardBreak` with logic that checks table context, computes current and next cells (`selectionCell`, `nextCell`), and moves selection to the start of the cell below (using prosemirror-tables helpers); imports updated to include `TextSelection` and cell-navigation helpers.
End-to-end Tests `tests/src/end-to-end/tables/tables.test.ts`	Adds two Playwright tests: `enterMovesToCellBelow` (Enter moves focus to cell below) and `shiftEnterNewLineInCell` (Shift+Enter inserts newline inside cell).
Test Snapshots `tests/src/end-to-end/tables/tables.test.ts-snapshots/...` `enterMovesToCellBelow-json--linux.json`, `shiftEnterNewLineInCell-json--linux.json`	Adds snapshot JSON fixtures for both scenarios across Chromium, Firefox, and WebKit targets that serialize the expected document state (table rows/cells, cell contents, and trailing paragraph container).

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Editor
    participant TableExtension
    participant ProseMirror
    User->>Editor: Press Enter (or Shift+Enter)
    Editor->>TableExtension: keydown event -> invoke handler
    TableExtension->>ProseMirror: check isInTable / selectionCell
    alt Shift+Enter
        TableExtension->>ProseMirror: insert hardBreak in current cell
        ProseMirror-->>TableExtension: updated doc/selection
        TableExtension-->>Editor: render/update
    else Enter
        TableExtension->>ProseMirror: compute nextCell (vertical)
        alt nextCell exists
            TableExtension->>ProseMirror: set selection to nextCell start (moveCellForward)
            ProseMirror-->>TableExtension: updated doc/selection
            TableExtension-->>Editor: scrollIntoView / render
        else no nextCell
            TableExtension-->>Editor: return false (no-op)
        end
    end

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 Hopping keys from cell to cell,
Enter skips down — a tidy spell.
Shift keeps lines where they belong,
The table hums a clearer song. ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: Enter key now moves selection to cell below in tables, which is the primary objective of this PR.
Description check	✅ Passed	The description follows the template with all major sections completed: Summary, Rationale, Changes, Impact, Testing, and Checklist. All required items are marked as done.
Linked Issues check	✅ Passed	The PR addresses both requirements from issue `#2409`: Enter moves focus to cell below [`#2409`], and Shift+Enter inserts new line in current cell [`#2409`].
Out of Scope Changes check	✅ Passed	All changes are directly related to the issue objectives: TableExtension.ts implements the Enter navigation logic, and test files verify the new behavior for both Enter and Shift+Enter cases.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch table-enter-handling

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@packages/core/src/blocks/Table/TableExtension.ts`:
- Around line 50-63: The handler is consuming Enter even when nextCell($cell,
"vert", 1) is null; change the logic so you only claim the key event when a next
cell exists and you dispatched a transaction: call dispatch with
TextSelection.between($nextCell, moveCellForward($nextCell)).scrollIntoView()
only if $nextCell is truthy, and return true in that branch; otherwise return
false so the key falls back to the default behavior. Ensure you reference
selectionCell, nextCell, moveCellForward, TextSelection and dispatch when
updating the control flow.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 14ad8bff-c819-4262-800b-03acb165893c

📥 Commits

Reviewing files that changed from the base of the PR and between 15b7dea and 664328a.

📒 Files selected for processing (8)

packages/core/src/blocks/Table/TableExtension.ts
tests/src/end-to-end/tables/tables.test.ts
tests/src/end-to-end/tables/tables.test.ts-snapshots/enterMovesToCellBelow-json-chromium-linux.json
tests/src/end-to-end/tables/tables.test.ts-snapshots/enterMovesToCellBelow-json-firefox-linux.json
tests/src/end-to-end/tables/tables.test.ts-snapshots/enterMovesToCellBelow-json-webkit-linux.json
tests/src/end-to-end/tables/tables.test.ts-snapshots/shiftEnterNewLineInCell-json-chromium-linux.json
tests/src/end-to-end/tables/tables.test.ts-snapshots/shiftEnterNewLineInCell-json-firefox-linux.json
tests/src/end-to-end/tables/tables.test.ts-snapshots/shiftEnterNewLineInCell-json-webkit-linux.json

pkg-pr-new · 2026-04-28T14:21:28Z

Open in StackBlitz

@blocknote/ariakit

npm i https://pkg.pr.new/@blocknote/ariakit@2685

@blocknote/code-block

npm i https://pkg.pr.new/@blocknote/code-block@2685

@blocknote/core

npm i https://pkg.pr.new/@blocknote/core@2685

@blocknote/mantine

npm i https://pkg.pr.new/@blocknote/mantine@2685

@blocknote/react

npm i https://pkg.pr.new/@blocknote/react@2685

@blocknote/server-util

npm i https://pkg.pr.new/@blocknote/server-util@2685

@blocknote/shadcn

npm i https://pkg.pr.new/@blocknote/shadcn@2685

@blocknote/xl-ai

npm i https://pkg.pr.new/@blocknote/xl-ai@2685

@blocknote/xl-docx-exporter

npm i https://pkg.pr.new/@blocknote/xl-docx-exporter@2685

@blocknote/xl-email-exporter

npm i https://pkg.pr.new/@blocknote/xl-email-exporter@2685

@blocknote/xl-multi-column

npm i https://pkg.pr.new/@blocknote/xl-multi-column@2685

@blocknote/xl-odt-exporter

npm i https://pkg.pr.new/@blocknote/xl-odt-exporter@2685

@blocknote/xl-pdf-exporter

npm i https://pkg.pr.new/@blocknote/xl-pdf-exporter@2685

commit: bfc12e1

nperez0111

This works as I'd expect it, thanks @matthewlipski

Made Enter move selection to cell below in tables

664328a

vercel Bot deployed to Preview – blocknote-website April 28, 2026 14:18 View deployment

coderabbitai Bot reviewed Apr 28, 2026

View reviewed changes

Comment thread packages/core/src/blocks/Table/TableExtension.ts

Implemented PR feedback

bfc12e1

vercel Bot deployed to Preview – blocknote April 28, 2026 14:55 View deployment

vercel Bot deployed to Preview – blocknote-website April 28, 2026 14:58 View deployment

matthewlipski requested a review from nperez0111 April 28, 2026 15:03

nperez0111 approved these changes Apr 29, 2026

View reviewed changes

matthewlipski merged commit 6dbd6eb into main Apr 29, 2026
23 checks passed

matthewlipski deleted the table-enter-handling branch April 29, 2026 12:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Enter moves selection to cell below in tables (BLO-1006)#2685

feat: Enter moves selection to cell below in tables (BLO-1006)#2685
matthewlipski merged 2 commits intomainfrom
table-enter-handling

matthewlipski commented Apr 28, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

vercel Bot commented Apr 28, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Apr 28, 2026 •

edited

Loading

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Poem

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

pkg-pr-new Bot commented Apr 28, 2026 •

edited

Loading

Uh oh!

nperez0111 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

matthewlipski commented Apr 28, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Rationale

Changes

Impact

Testing

Screenshots/Video

Checklist

Additional Notes

Summary by CodeRabbit

Uh oh!

vercel Bot commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Poem

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pkg-pr-new Bot commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nperez0111 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

matthewlipski commented Apr 28, 2026 •

edited by coderabbitai Bot

Loading

vercel Bot commented Apr 28, 2026 •

edited

Loading

coderabbitai Bot commented Apr 28, 2026 •

edited

Loading

pkg-pr-new Bot commented Apr 28, 2026 •

edited

Loading