fix(core): add editor cleanup in BlockNoteEditor.test.ts

[nperez0111]

Problem

The Fresh Install Tests CI workflow fails at the "Run unit tests" step with:

ReferenceError: document is not defined
 ❯ EditorView.get root [as root] prosemirror-view/dist/index.js:5665:26
 ❯ EditorView.domSelection prosemirror-view/dist/index.js:5824:21
 ❯ DOMObserver.flush prosemirror-view/dist/index.js:4714:24
 ❯ Timeout._onTimeout prosemirror-view/dist/index.js:4644:46

All 28 test files pass individually (449 tests), but Vitest catches 1 unhandled error originating from BlockNoteEditor.test.ts.

Root Cause

Two tests (sets an initial block id when using Y.js and onBeforeChange) call editor.mount() to create a ProseMirror EditorView but never call editor.unmount(). This leaves ProseMirror's DOMObserver active with a 20ms setTimeout that fires after jsdom is torn down, causing the document is not defined error.

When pnpm update --prod bumps prosemirror-view to 1.41.8, timing changes make this latent bug surface.

Fix

Add an afterEach cleanup hook that calls editor.unmount() on all editors created during each test, following the same pattern already used in transformPasted.test.ts. This ensures EditorView.destroy() is called, which sets docView = null so any lingering DOMObserver timers bail out harmlessly.

Testing

• vitest run src/editor/BlockNoteEditor.test.ts — 8/8 tests pass, 0 unhandled errors

Summary by CodeRabbit

• Tests
  • Improved test cleanup infrastructure to automatically unmount editor instances after each test, ensuring proper resource management and preventing test interference.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
blocknote	Ready	Preview	Jun 1, 2026 2:04pm
blocknote-website	Ready	Preview	Jun 1, 2026 2:04pm

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0174bfb8-4bed-417e-a007-5b4777cb6054

📥 Commits

Reviewing files that changed from the base of the PR and between faae3d5 and 64937b1.

📒 Files selected for processing (1)

• packages/core/src/editor/BlockNoteEditor.test.ts

---

📝 Walkthrough

Walkthrough

The test file now implements centralized cleanup for created BlockNoteEditor instances. A shared editorsToCleanup array collects references, and an afterEach hook automatically unmounts all tracked editors following each test execution. Six existing tests were updated to register their editors for cleanup.

Changes

BlockNoteEditor Test Cleanup

Layer / File(s)	Summary
Cleanup infrastructure and Vitest imports packages/core/src/editor/BlockNoteEditor.test.ts	Vitest import updated to include afterEach; editorsToCleanup array and afterEach hook added to unmount all tracked editors after each test.
Test cleanup registration packages/core/src/editor/BlockNoteEditor.test.ts	Six tests ("adds id attribute when requested", "updates block", "block prop types", "onMount and onUnmount", "sets an initial block id when using Y.js", "onBeforeChange") updated to register their created editors in editorsToCleanup.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

Possibly related PRs

• TypeCellOS/BlockNote#2660: Both PRs update Vitest test files to track created BlockNoteEditor instances and add an afterEach cleanup hook that unmounts editors after each test.

Suggested reviewers

• matthewlipski

Poem

🐰 A cleanup brigade marches through tests, whoosh!
Each editor bows, unmounts with a poosh,
No leaks left behind, just order and care,
The afterEach hook makes fixtures so fair! 🎪

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: adding editor cleanup functionality in BlockNoteEditor.test.ts to fix a critical CI issue.
Description check	✅ Passed	The description is well-structured and comprehensive, covering problem statement, root cause analysis, and the implemented fix, though it deviates from the template structure by using custom sections instead.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fresh-install-fixes-2

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[pkg-pr-new]

Open in StackBlitz

@blocknote/ariakit

npm i https://pkg.pr.new/@blocknote/ariakit@2816

@blocknote/code-block

npm i https://pkg.pr.new/@blocknote/code-block@2816

@blocknote/core

npm i https://pkg.pr.new/@blocknote/core@2816

@blocknote/mantine

npm i https://pkg.pr.new/@blocknote/mantine@2816

@blocknote/react

npm i https://pkg.pr.new/@blocknote/react@2816

@blocknote/server-util

npm i https://pkg.pr.new/@blocknote/server-util@2816

@blocknote/shadcn

npm i https://pkg.pr.new/@blocknote/shadcn@2816

@blocknote/xl-ai

npm i https://pkg.pr.new/@blocknote/xl-ai@2816

@blocknote/xl-docx-exporter

npm i https://pkg.pr.new/@blocknote/xl-docx-exporter@2816

@blocknote/xl-email-exporter

npm i https://pkg.pr.new/@blocknote/xl-email-exporter@2816

@blocknote/xl-multi-column

npm i https://pkg.pr.new/@blocknote/xl-multi-column@2816

@blocknote/xl-odt-exporter

npm i https://pkg.pr.new/@blocknote/xl-odt-exporter@2816

@blocknote/xl-pdf-exporter

npm i https://pkg.pr.new/@blocknote/xl-pdf-exporter@2816

commit: 64937b1