Skip to content

Designed new API and simple example#43

Merged
JohannesMeierSE merged 7 commits intomainfrom
jm/chaining-api
Dec 12, 2024
Merged

Designed new API and simple example#43
JohannesMeierSE merged 7 commits intomainfrom
jm/chaining-api

Conversation

@JohannesMeierSE
Copy link
Copy Markdown
Collaborator

@JohannesMeierSE JohannesMeierSE commented Dec 10, 2024

@JohannesMeierSE JohannesMeierSE marked this pull request as ready for review December 11, 2024 16:59
Copy link
Copy Markdown
Member

@insafuhrmann insafuhrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great joint work session @JohannesMeierSE and for the additions and fixes afterwards. The Functions escaped the renaming from predefined to factory, otherwise everything seems fine to me.

Comment thread packages/typir/src/kinds/function/function-kind.ts Outdated
@JohannesMeierSE JohannesMeierSE merged commit 54b0191 into main Dec 12, 2024
@JohannesMeierSE
Copy link
Copy Markdown
Collaborator Author

Thanks @insafuhrmann for the great joint working session!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants