Skip to content

Conversation

@jbrantly
Copy link
Member

@jbrantly jbrantly commented Nov 4, 2015

One of the tests relied on TS failing on a comment in tsconfig.json. This PR addresses that.

@blakeembrey

@blakeembrey
Copy link
Member

LGTM 👍 Might want to check what Travis is grouching about - seems the output has changed.

@jbrantly
Copy link
Member Author

jbrantly commented Nov 4, 2015

Yea, there's three diff issues with the unit tests. This one, #96 and then apparently a new Babel version changed some output :( working on getting everything passing again. Thanks!

jbrantly added a commit that referenced this pull request Nov 4, 2015
…ents

Update tests now that tsconfig.json allows comments
@jbrantly jbrantly merged commit d377956 into master Nov 4, 2015
@johnnyreilly johnnyreilly deleted the update-tests-for-tsconfig-comments branch July 13, 2017 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants