Skip to content

Conversation

@natevoci
Copy link
Contributor

Added a check for if symbol.declarations is undefined to avoid the exception described in issue #513.

I reproduced this issue when someone added a file to our project that just exported another module.

import { HotkeysTarget } from '@blueprintjs/core';
export default HotkeysTarget;

When debugging I found that with this export the symbol object does not have a declarations property. It just has

{
  checkFlags: 0,
  flags: 134217732
  name: "unknown"
  type: {checker, flags: 1, id: 3, intrinsicName: "unknown"}
}

so I have just added a condition so that we don't try and call forEach on declarations if it doesn't exist.

@TobyColeman
Copy link

Any movement on this? Experiencing the same problem

@buschtoens
Copy link

@TobyColeman Take a look at the recent comments in #513. 😉

@blakeembrey blakeembrey merged commit be929bb into TypeStrong:master Jul 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants