Skip to content

Fixed issue 513 by checking if the decorators are undefined in the ex… #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blakeembrey merged 1 commit into from
Jul 25, 2017
Merged

Fixed issue 513 by checking if the decorators are undefined in the ex… #562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 19 additions & 15 deletions src/lib/converter/nodes/export.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,21 +25,25 @@ export class ExportConverter extends ConverterNodeComponent<ts.ExportAssignment>
}
if (symbol) {
const project = context.project;
symbol.declarations.forEach((declaration) => {
if (!declaration.symbol) {
return;
}
const id = project.symbolMapping[context.getSymbolID(declaration.symbol)];
if (!id) {
return;
}

const reflection = project.reflections[id];
if (node.isExportEquals && reflection instanceof DeclarationReflection) {
(<DeclarationReflection> reflection).setFlag(ReflectionFlag.ExportAssignment, true);
}
markAsExported(reflection);
});
// if the symbol declarations are undefined due to an export, we skip it
// fixes https://github.com/TypeStrong/typedoc/issues/513
if (symbol.declarations) {
symbol.declarations.forEach((declaration) => {
if (!declaration.symbol) {
return;
}
const id = project.symbolMapping[context.getSymbolID(declaration.symbol)];
if (!id) {
return;
}

const reflection = project.reflections[id];
if (node.isExportEquals && reflection instanceof DeclarationReflection) {
(<DeclarationReflection> reflection).setFlag(ReflectionFlag.ExportAssignment, true);
}
markAsExported(reflection);
});
}
}

function markAsExported(reflection: Reflection) {
Expand Down
2 changes: 1 addition & 1 deletion src/test/renderer/specs/classes/_default_export_.defaultexportedclass.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ <h1>Class DefaultExportedClass</h1>
<div class="lead">
<p>This class is exported via es6 export syntax.</p>
</div>
<pre><code><span class="hljs-keyword">export</span> <span class="hljs-keyword">default</span> <span class="hljs-class"><span class="hljs-keyword">class</span> <span class="hljs-title">DefaultExportedClass</span></span>
<pre><code><span class="hljs-builtin-name">export</span><span class="hljs-built_in"> default </span>class DefaultExportedClass
</code></pre>
</div>
</section>
Expand Down