fix(cli): render dim labels with gray so colors show in GitHub Actions (#323)#631
Merged
Conversation
SGR 2 (faint/dim) is not rendered by the GitHub Actions log UI, so keywords like `Expected`, `Tests:` and `Assertions:` appeared without any color in CI while looking dim locally. Switch the `_BASHUNIT_COLOR_FAINT` constant to SGR 90 (bright black / gray), which is widely supported across terminals and CI renderers. Closes #323
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_BASHUNIT_COLOR_FAINTfrom SGR 2 (faint) to SGR 90 (bright black / gray) so keywords likeExpected,Tests:andAssertions:stay colored in GitHub Actions logs, which don't render the faint attribute.bashunit_execution_error_test.shhelper and the 27 acceptance snapshots that captured the previous\e[2msequence._BASHUNIT_COLOR_FAINTto the gray code.Why
Per #323,
Expected/to containwere colored locally on macOS/iTerm but invisible in GitHub Actions logs. The root cause is that the GitHub Actions web log renderer does not render SGR 2 (faint/dim). SGR 90 is supported everywhere and looks visually similar.Test plan
BEFORE
AFTER
Closes #323