refactor(runner): extract login profile sourcing and verbose summary#653
Merged
Merged
Conversation
Split two self-contained blocks out of `bashunit::runner::run_test` into named helpers (`source_login_shell_profiles`, `print_verbose_test_summary`) so the hot path reads top-down. Pure extraction, no behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Background
bashunit::runner::run_testis ~320 lines with several self-contained side concerns inlined inside its subshell. Hard to navigate, hard to test in isolation.💡 Changes
bashunit::runner::source_login_shell_profiles— bundles the four[ -f ~/.bash* ] && sourcelines that the subshell ran when--loginwas activebashunit::runner::print_verbose_test_summary— bundles the verbose-mode header/printf scaffolding into a single helper that takes file/fn/duration/resulttests/acceptance/bashunit_login_shell_test.sh