Skip to content

feat(NOJIRA-123): add Playwright visual regression test support to deploy workflow#230

Merged
bobobowis merged 1 commit intomainfrom
feat/add-playwright-visual-tests
Apr 23, 2026
Merged

feat(NOJIRA-123): add Playwright visual regression test support to deploy workflow#230
bobobowis merged 1 commit intomainfrom
feat/add-playwright-visual-tests

Conversation

@bobobowis
Copy link
Copy Markdown
Contributor

@bobobowis bobobowis commented Apr 23, 2026

Summary

Add support for running Playwright visual regression tests in the frontend-deploy-workflow, matching the existing functionality already available in the frontend-pr-workflow.

This enables projects using Playwright for visual regression testing (like admin-home) to run these tests as part of their production release pipeline.

Changes

New inputs

  • run-playwright-visual: Enable/disable Playwright visual tests (default: false)
  • playwright-visual-command: Command to run visual tests (default: 'yarn test:visual')
  • playwright-visual-timeout: Test timeout in minutes (default: 20)

New job

  • Job 6: Playwright Visual Tests - Runs in parallel with other test jobs

Deploy job updates

  • Added playwright-visual to deploy job dependencies
  • Deploy only proceeds if Playwright visual tests pass (when enabled)

Consistency with PR workflow

This implementation mirrors the existing playwright-visual job in frontend-pr-workflow.yml, ensuring consistent behavior across PR checks and production deployments.

Test plan

  • Verify workflow syntax is valid
  • Test with a project using Playwright visual tests (e.g., admin-home)
  • Confirm tests run in parallel with other test jobs
  • Verify deploy job waits for visual tests to complete
  • Confirm artifacts are uploaded correctly

@gitstream-cm
Copy link
Copy Markdown

gitstream-cm Bot commented Apr 23, 2026

🥷 Code experts: kb-typeform

kb-typeform has most 👩‍💻 activity in the files.
kb-typeform has most 🧠 knowledge in the files.

See details

.github/workflows/frontend-deploy-workflow.yml

Activity based on git-commit:

kb-typeform
APR 4 additions & 0 deletions
MAR 59 additions & 31 deletions
FEB 374 additions & 9 deletions
JAN 9 additions & 1 deletions
DEC 292 additions & 12 deletions
NOV

Knowledge based on git-blame:
kb-typeform: 98%

✨ Comment /gs review for LinearB AI review. Learn how to automate it here.

Comment thread .github/workflows/frontend-deploy-workflow.yml Fixed
Comment thread .github/workflows/frontend-deploy-workflow.yml Fixed
@bobobowis
Copy link
Copy Markdown
Contributor Author

Note: SonarCloud is flagging run: ${{ inputs.playwright-visual-command }} and run: ${{ inputs.pre-test-command }} as potential script injection vulnerabilities.

However, this is the existing pattern used throughout this entire workflow for all command inputs (inputs.integration-test-command, inputs.unit-test-command, inputs.build-command, etc.).

For consistency, I'm keeping the same approach. If we want to fix this security warning, it should be done in a separate PR that updates all command executions in the workflow, not just the new Playwright visual job.

Comment thread .github/workflows/frontend-deploy-workflow.yml Fixed
Comment thread .github/workflows/frontend-deploy-workflow.yml Fixed
@bobobowis bobobowis force-pushed the feat/add-playwright-visual-tests branch 3 times, most recently from 8bd417a to 5507a83 Compare April 23, 2026 12:14
…eploy workflow

Add optional Playwright visual regression testing step to the frontend deployment workflow. The new job runs in parallel with other test suites and integrates with VRT service for visual diff tracking.

Changes:
- Add workflow inputs: run-playwright-visual, playwright-visual-command, playwright-visual-timeout
- Add playwright-visual job that uses shared-actions/run-playwright-visual@v1
- Pass VRT configuration (branch name, build ID, API credentials) to the visual test job
- Update job numbering in comments (SonarCloud: Job 6→7, Deploy: Job 7→8, Notify: Job 8→9)
@bobobowis bobobowis force-pushed the feat/add-playwright-visual-tests branch from 5507a83 to 07511c4 Compare April 23, 2026 12:20
@sonarqubecloud
Copy link
Copy Markdown

@bobobowis bobobowis changed the title feat: add Playwright visual regression test support to deploy workflow feat(NOJIRA-123): add Playwright visual regression test support to deploy workflow Apr 23, 2026
@bobobowis bobobowis merged commit 7fecf91 into main Apr 23, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants