Create a new pull request by comparing changes#824
Merged
GulajavaMinistudio merged 10 commits intoTypescriptID:masterfrom May 13, 2022
Merged
Create a new pull request by comparing changes#824GulajavaMinistudio merged 10 commits intoTypescriptID:masterfrom
GulajavaMinistudio merged 10 commits intoTypescriptID:masterfrom
Conversation
Create a new page, which describes the basic features of the new reactive forms types, and describes how to migrate to them. PR Close #45939
This change adds the capability of ngc_wrapped to emit an unused_inputs_list file that could be used by starlark. We are making this change because in situations where angular modules depend on angular modules, it becomes very easy for a single change to trigger a long cascading set of angular builds since each angular rule depends on the transitive closure of input files. With this change in place, and once it is properly configured, bazel will update the set of inputs to a build rule after it is built once removing any of the inputs specified in this list, making incremental builds quicker by skipping any rebuilds that only had changes to unused inputs. This logic should be, and is likely duplicated in tsc_wrapped to solve the same problem in pure TypeScript situations, ideally we could use the same implementation one day. In addition, its possible that tree artifacts are not as supported as we'd like, and where this change should mark entire directories as unused, we may get better performance gains by enumerating the directory and being more explicit about specific inputs which are unused. PR Close #45946
Previously, the preview server would incorrectly identify a running `aio_preview` CI job as failed and therefore skip creating a preview. This happened because it only checked whether the job's status is `success`, failing to account for the fact that the job would have a `running` status. (This bug was accidentally introduced in #45934.) This commit avoids the problem by getting rid of the job status check altogether. This check does not offer any benefit, since the CI job will always be in a `running` state (i.e. neither successfully completed nor failed). PR Close #45948
Add support to material design icons in offline mode for Angular Devtools. Self hosting the web font so icons are loaded regardless of network connection. Bring the font file as well as its corresponding css file from third_party repo through bazel into shell-browser directory while building. PR Close #45743
…project (#45965) As part of the `updateProjectIfDirty` process and inside `updateNonInferredProjectFiles` TS Server will remove the template files that we added as roots in `readResource`. https://sourcegraph.com/github.com/microsoft/TypeScript@c300fea3250abd7f75920d95a58d9e742ac730ee/-/blob/src/server/editorServices.ts?L2363 The external files are added to the list here so ensuring that the templates are included in the `getExternalFiles` will prevent this from happening https://sourcegraph.com/github.com/microsoft/TypeScript@c300fea3250abd7f75920d95a58d9e742ac730ee/-/blob/src/server/editorServices.ts?L2395:18 PR Close #45965
…es (#45975) Rather than using git init to create an empty repo and then shallow fetch the repo for a specific branch, we shallow clone the repository itself for the branch. This prevents us from running into the issue of Github denying the push because it comes from a shallow branch which does not map back to the repository. PR Close #45975
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information