Create a new pull request by comparing changes across two branches#897
Merged
GulajavaMinistudio merged 15 commits intoTypescriptID:masterfrom Oct 20, 2022
Merged
Create a new pull request by comparing changes across two branches#897GulajavaMinistudio merged 15 commits intoTypescriptID:masterfrom
GulajavaMinistudio merged 15 commits intoTypescriptID:masterfrom
Conversation
) This commit adds a missing warning if the image directive detects that you're hosting your image on one of our supported image CDNs but you're not using the built-in loader for it. This excludes applications that are using a custom loader. PR Close #47330
The current error that is thrown when the "width" or "height" attributes is missing doesn't mention that "fill" mode is another option. This commit updates the error with that option. PR Close #47797
This is a small commit to: - clarify that loaders aren't mandatory - remove outdated preconnect option from docs - clarify how width/height should be set for fixed size images - minor structural changes for clarity PR Close #47796
In v14.2, we've introduced a new directive to help developers to configure images for better performance. The directive was initially released in the "developer preview" mode. We've collected the feedback, made several improvements and we are happy to announce that the NgOptimizedImage APIs are promoted to stable! This commit updates vast majority of APIs to drop the `@developerPreview` label, which effectively documents them as stable. There are few APIs though that retained the `@developerPreview` annotations: - the `IMAGE_CONFIG` token - the `ImageConfig` type - the `fill` @input of the directive We plan to collect some additional feedback for the mentioned APIs and drop the `@developerPreview` annotation after that. PR Close #47794
Do not generate a srcset if the loader being used is the default noopImageLoader. This loader does not take width into account, so it does not make sense to use it with srcsets. PR Close #47804
This commit adds the `@nodoc` annotations to the lifecycle hooks of the `NgOptimizedImage` directive to exclude them from the docs. PR Close #47814
…e rendered (#47563) Currently, the scroll event is fired immediately after the `NavigationEnd`. However, this is problematic because a change detection has not been able to run, meaning that Angular will not yet have run the update block of the component templates being rendered as part of the navigation. This change delays the scroll event using a `setTimeout`, which will allow Angular's change detection to run before the scroll restoration is performed. fixes #24547 PR Close #47563
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information