Skip to content

21 remove simplified concept from network overline#22

Merged
temospena merged 5 commits intomainfrom
21-remove-simplified-concept-from-network_overline
Jun 6, 2025
Merged

21 remove simplified concept from network overline#22
temospena merged 5 commits intomainfrom
21-remove-simplified-concept-from-network_overline

Conversation

@gmatosferreira
Copy link
Copy Markdown
Member

Renamed attributes:

  • network to target_network
  • dfto lines
  • network_segment_length to target_network_split

Improved documentation, explaining different with GTFShift::get_route_frequency_hourly using overline=TRUE.

@gmatosferreira gmatosferreira linked an issue Jun 5, 2025 that may be closed by this pull request
@gmatosferreira gmatosferreira requested a review from temospena June 5, 2025 15:24
Copy link
Copy Markdown
Member

@temospena temospena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure that this modifications work well globally.
use "find in files" the replaced variables to see if something missing.

Comment thread vignettes/analyse.Rmd Outdated
@gmatosferreira gmatosferreira requested a review from temospena June 6, 2025 09:55
@temospena temospena merged commit bdcb0f2 into main Jun 6, 2025
1 check passed
@temospena temospena deleted the 21-remove-simplified-concept-from-network_overline branch June 6, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove "simplified" concept from network_overline

2 participants