Skip to content

23 integrate osm route mapping#24

Merged
temospena merged 13 commits intomainfrom
23-integrate-osm-route-mapping
Jun 13, 2025
Merged

23 integrate osm route mapping#24
temospena merged 13 commits intomainfrom
23-integrate-osm-route-mapping

Conversation

@gmatosferreira
Copy link
Copy Markdown
Member

@gmatosferreira gmatosferreira commented Jun 12, 2025

  • Implemented method osm_shapes_match_routes to find OSM routes matching GTFS shapes geometry;
  • Implemented methods osm_shapes_to_routes and osm_trips_to_routes to get OSM geometry given a match with GTFS feed shapes/trips ids;
  • Updated osm and analysis vignettes, to document the new changes with examples;
  • Created script to update bus routes at OSM database with shape_id, stored at inst/python/osm_routes_add_shapes.py;
  • Validated manually (script at dev folder) for Rennes, FR.

@gmatosferreira gmatosferreira linked an issue Jun 12, 2025 that may be closed by this pull request
@gmatosferreira gmatosferreira requested a review from temospena June 12, 2025 15:50
Copy link
Copy Markdown
Member

@temospena temospena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it, nice job!

I wonder why you removed the () from the functions at the vignettes, but we can discuss that later.

@temospena temospena merged commit 63a80e8 into main Jun 13, 2025
1 check passed
@temospena temospena deleted the 23-integrate-osm-route-mapping branch June 13, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrate OSM route mapping

2 participants