Skip to content

Update README, update mirror output, update test_mirror to reflect changes in mirror#18

Merged
everittB merged 2 commits into
masterfrom
alycia
Feb 17, 2019
Merged

Update README, update mirror output, update test_mirror to reflect changes in mirror#18
everittB merged 2 commits into
masterfrom
alycia

Conversation

@alyciakb
Copy link
Copy Markdown
Collaborator

@alyciakb alyciakb commented Feb 17, 2019

  • First draft of our updated README. Includes install and usage instructions, plus package dependencies. Please review (especially your functions) and make changes as needed.
  • Install and package has been tested in my console and works. Please check to make sure it works in your console.
  • Updated mirror.py to include the original image in the output array
  • Updated test_mirror.py to reflect changes in the mirror function and changes in the output array size.

@alyciakb alyciakb added this to the Milestone2 milestone Feb 17, 2019
@alyciakb alyciakb changed the title Add install and usage instructions to README Update README, update mirror output, update test_mirror to reflect changes in mirror Feb 17, 2019
Copy link
Copy Markdown
Collaborator

@everittB everittB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the install instructions they differ from what was provided in Milestone2 guideline, pip install git+PACKAGE_URL.git, I will see if installing it this way works as well.

@everittB everittB merged commit 5a27044 into master Feb 17, 2019
@alyciakb
Copy link
Copy Markdown
Collaborator Author

  • Install works both ways, but changed the install directions to be in compliance with the milestone2 directions. Added the changes to the Update function documentation, minor changes to README pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants