Fix entity reference field key and add null safety for taxonomy term loading#17
Merged
Conversation
Co-authored-by: protitude <695625+protitude@users.noreply.github.com> Agent-Logs-Url: https://github.com/UCBoulder/oit/sessions/8e098423-2adf-4adb-a230-aefd77eab276
Copilot
AI
changed the title
[WIP] [WIP] Address feedback from review on Media 1202 pull request
Fix entity reference field key and add null safety for taxonomy term loading
Mar 25, 2026
protitude
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
field_service_alert_dash_catis an entity reference field, but its referenced entity ID was being read via['value']instead of['target_id'], causingload()to receive bad input and returnNULL— followed by a fatal on$taxonomy->get(...).Changes
getValue()[0]['value']→getValue()[0]['target_id']to correctly retrieve the referenced term IDif ($taxonomy !== NULL)guard afterload()!empty($tax_image_values)before accessing[0]['target_id']onfield_twitter_image📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.