Expand save data for Star Map#75
Merged
Merged
Conversation
thompson318
reviewed
May 7, 2026
Member
thompson318
left a comment
thompson318
left a comment
There was a problem hiding this comment.
Looks good. I think the StarMapScores.csv file implements David's instructions correctly.
I did pick up a bug when starting with an empty save directory, see comment. Can you please take a look at that then I'll retest.
thompson318
approved these changes
May 7, 2026
Member
thompson318
left a comment
thompson318
left a comment
There was a problem hiding this comment.
I think this works as intended and meets the requirements set by David. The changes introduced to enable multi item reading and writing look well thought out and appropriate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #20
See some further clarifications from David on the corresponding issue
Expands StarMap save data:
GetLastNCompleteGamesso that it returns all rows associated with the last n complete games. For StarMap, this will be multiple rows per game == the number of trials.StarMapdocs with explanation of save data