Expand zero gravity save data#78
Merged
Merged
Conversation
…into km/zero-gravity-data
thompson318
approved these changes
May 14, 2026
Member
thompson318
left a comment
There was a problem hiding this comment.
This looks good to me. Following the same pattern as the other minigames so is easily comprehensible and well documented.
I like the buffer refactor, it makes the buffer more flexible and avoids the need for two pose buffers in in 🚀 launch, which is good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #20
See extra info from David on the issue: #20 (comment)
TrackerBuffersso it could handle both head position (x/y/z) and angle (roll/pitch/yaw) data. Even though this is no longer needed for this PR I thought I'd leave it in as:RocketLaunchwe no longer need to store the same head pose data in two separate buffers to get the pitch and yaw velocities - we can store the data once and calculate both directly from there.