Update transform panel to include seed boolean#33
Merged
Conversation
3 tasks
…rgument and .sh script to launch with specificed randomisation seed
sfmig
requested changes
Apr 21, 2023
Collaborator
sfmig
left a comment
sfmig
left a comment
There was a problem hiding this comment.
Looks alright! But I have requested some changes, and have three larger comments:
- There were a few breakpoints from the Python debugger here and there. When I removed them, I got the following error:
-
I realised we use a different approach to generate random numbers . I use numpy's random number generator and you use the random module. It is probably a good idea to make it consistent. I guess this is related to expanding this PR to also apply the same seed to the materials panel. So maybe we can cover it in that future PR? Happy to chat about it, or if you agree feel free to open an issue.
-
I think we can remove some of the commented blocks, and if you can add docstrings to the functions that would be great.
Co-authored-by: sfmig <33267254+sfmig@users.noreply.github.com>
Co-authored-by: sfmig <33267254+sfmig@users.noreply.github.com>
Co-authored-by: sfmig <33267254+sfmig@users.noreply.github.com>
Co-authored-by: sfmig <33267254+sfmig@users.noreply.github.com>
Co-authored-by: sfmig <33267254+sfmig@users.noreply.github.com>
Co-authored-by: sfmig <33267254+sfmig@users.noreply.github.com>
Co-authored-by: sfmig <33267254+sfmig@users.noreply.github.com>
Co-authored-by: sfmig <33267254+sfmig@users.noreply.github.com>
Co-authored-by: sfmig <33267254+sfmig@users.noreply.github.com>
Co-authored-by: sfmig <33267254+sfmig@users.noreply.github.com>
Collaborator
Author
|
…ommented out blocks
Closed
sfmig
approved these changes
Apr 24, 2023
Collaborator
sfmig
left a comment
sfmig
left a comment
There was a problem hiding this comment.
looks great!
One thing I noticed when testing it out is that when I launch it with sh randomisation_seed.sh, the seed is set to the value in the bash script but the randomisation toggle is set to False. I think it would be nice to have it set to True if a seed is passed as a command line argument.
The rest are very minor things
| rot_y_range, | ||
| rot_z_range, | ||
| delta_on, | ||
| seed_no, |
Collaborator
There was a problem hiding this comment.
can we add a docstring for this?
Co-authored-by: sfmig <33267254+sfmig@users.noreply.github.com>
Co-authored-by: sfmig <33267254+sfmig@users.noreply.github.com>
Co-authored-by: sfmig <33267254+sfmig@users.noreply.github.com>
Co-authored-by: sfmig <33267254+sfmig@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seed boolean added to transform panel
Modified install_and_enable_addons.py to include an additional randomisation seed argument
randomisation_seed.sh script to automate with an example seed of 32