Add optional randomisation seed argument#43
Merged
Conversation
sfmig
approved these changes
Apr 25, 2023
Collaborator
sfmig
left a comment
sfmig
left a comment
There was a problem hiding this comment.
LGTM!
Both sh scripts work ✅ ✅
I added a commit to have the short and long version of the seed flag, but feel free to revert if you find errors on your side (It was working fine for me).
Collaborator
Author
It works fine for me so I'm going to merge |
1 similar comment
Collaborator
Author
It works fine for me so I'm going to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
install_enable_addons.py script has been updated which now works with both:
Related to #34 but doesn't close this issue as still have to add in a config file as an optional argument in the future