Allow input nodes inside groups to be randomised#47
Merged
Conversation
…de inside a group (prepend the group name)
Collaborator
Author
|
One potential problem with this PR as it is (probably good to discuss tomorrow with @tdowrick):
|
ruaridhg
reviewed
May 10, 2023
ruaridhg
reviewed
May 10, 2023
Collaborator
ruaridhg
left a comment
There was a problem hiding this comment.
LGTM, there may be a repeated for loop in operators that is redundant but looks sensible apart from that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Input nodes are defined as nodes in the graph with no input sockets. The input nodes to randomise are identified because their name is prefixed with a prefix (typically 'random', case insensitive).
With this PR both independent nodes, and nodes inside a group are searched. The 'artificial' nodes that show up inside a node group, usually named 'Group input' or 'Group output' are excluded from the search.
Will close #8