Conversation
… property group of custom props
…r property_classes
sfmig
approved these changes
Oct 16, 2023
Collaborator
sfmig
left a comment
sfmig
left a comment
There was a problem hiding this comment.
looks good! Most comments are about making it a bit more succinct, remove stuff or clarifying some bits.
Some scripts look like they'd need to be removed before going public with the repo.
Co-authored-by: sfmig <33267254+sfmig@users.noreply.github.com>
ruaridhg
force-pushed
the
rmg/docs_on_gh
branch
from
e28a6d3 to
147477d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #71