SPECTUB clean-up #1577
Merged
SPECTUB clean-up #1577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make wmh and some other arguments to functions const - remove some functions that are not used in STIR - replace boost::constants::pi with STIR's _PI - remove unused include files
- replace math.h with cmath etc - removed unused headers - add Apache 2.0 license to Pinhole code
KrisThielemans
force-pushed
the
SPECTUB_clean
branch
from
1c71ef0 to
bb1d2b3
Compare
Collaborator
Author
|
@mastergari @danieldeidda There are a bit too many changes here, but if you ignore all the "eliminate dead code" stuff, it should be harmless.... |
Collaborator
Author
|
@jchan192, feel like doing a recon with this PR and see if it changes anything? (it shouldn't!) |
Collaborator
Author
|
I'm going to merge this as nobody seems to have time for further testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wmhand some other arguments to functionsconstboost::constants::piwith STIR's_PIstd::cosfetc)There should be no functionality change here.
Note though that as the SPECTUB code contains structs with pointers, having a
conststruct isn't very definite (as whatever is being pointed to can still be changed).